UART framing API #24335
Closed
UART framing API #24335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Jul 26, 2023
andyp1per
force-pushed
the
pr-uart-frame
branch
2 times, most recently
from
998fbfd
to
75a666b
Compare
tridge
requested changes
Sep 6, 2023
There was a problem hiding this comment.
I'd like to try a simpler version that only holds 1 frame, if a new frame arrives while we have a frame pending then we discard the old frame
I can't immediately think of a case where we need multi-frame, but if we do we could add that once this has settled in
andyp1per
force-pushed
the
pr-uart-frame
branch
from
75a666b
to
4fcf5af
Compare
tridge
reviewed
Sep 27, 2023
tridge
reviewed
Sep 27, 2023
andyp1per
commented
Nov 22, 2023
andyp1per
commented
Nov 22, 2023
andyp1per
force-pushed
the
pr-uart-frame
branch
2 times, most recently
from
7f91b10
to
e0d6b16
Compare
…ate end of frames ensure that DMA transfers triggered by IDLE line occur before framing start and stop serial device when changing config
check sync byte for GHST and CRSF to avoid confusing the two protocols do not change baudrate when scanning GHST protocol unless specifically configured
andyp1per
force-pushed
the
pr-uart-frame
branch
from
e0d6b16
to
41d652e
Compare
|
Now working with A/B variant and cleaned up. Actually found some subtle issues with CRSFv3 and IDLE frames. Flown briefly on my 3" |
do not change to GHST baudrate unless it has been specifically configured
|
This turned out to have too many problems and doesn't actually work reliably on TBS kit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a UART framing API and uses it in our CRSF protocol implementation.
Flown briefly using CRSF tracer on a 3" quad.